P/L w/ or w/o fees toggle - Githubissues

rysk-finance / dynamic-hedging

Options delta neutrality as a crypto native uncorrelated asset class

rysk-dynamic-hedging.vercel.app

58 stars 8 forks source link

P/L w/ or w/o fees toggle #714

Closed MeanBoyCousin closed 1 year ago

MeanBoyCousin commented 1 year ago

Description

Fixes a bug where fees on certain models weren't accurately reflecting the position size.
Now showing the date as long and short for a user if they have a spread.
Adds a new toggle to the active positions to show P/L or ROI with or without fees included.
Extended the toggle to the Active & Historical P/L widgets.
Now showing premium paid/received in modals without fees.

Deployment notes:

Requires subgraph version 1.4.0 to be set to production.

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Document update
[ ] Quality of life improvement
[ ] Package upgrades

Checklist

[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[ ] I have NATSPEC'd any new functions
[x] If appropriate, I have properly tested my new functionality