search

rystanley / genepopedit

Simple and flexible manipulation of genomic data.
15 stars 4 forks source link

testing genepopedit #1

Closed thierrygosselin closed 7 years ago

thierrygosselin commented 7 years ago

Hi Ryan so this is the first step to do. Additional pull request will be send to pass R CMD check and travis CI... but one step at a time.

Hope you enjoyed the CSEE meeting in Newfoundland! Cheers Thierry

thierrygosselin commented 7 years ago

Have you branched before ? let me know if you need help.

As for the other warnings or notes in R CMD check results provided in the log, here is the solution:

  1. For global environment problem, first read this: see here for info

  2. To suppress those message during R CMD check:

    if(getRversion() >= "2.15.1") {
utils::globalVariables(
 c("string", "of", "your", "variable")
)
}

  3. For messages about: read.csv, read.table, setTxtProgressBar, txtProgressBar, write.table, 2 solutions:

    • import the necessary packages: devtools::use_package(package = utils, type = "Imports")
    • or use utils::setTxtProgressBar

    Make sure your working directory is the package path for this to work

rystanley commented 7 years ago

Hey,

So this will be my first pull request. I am seeing a message that I can merge your suggestions.

What edits did you do? If by merging I assume it only changes the edits you have loaded?

Thanks for all the help! You have inspired me to the power of Github for sure.