search

rytilahti / python-miio

Python library & console tool for controlling Xiaomi smart appliances
https://python-miio.readthedocs.io
GNU General Public License v3.0
3.52k stars 542 forks source link

Add Roborock S8 Pro Ultra #1891

Closed spangenberg closed 4 months ago

spangenberg commented 5 months ago

Fixes #1864

spangenberg commented 5 months ago

CI / Perform linting checks are unrelatedly failing and are also currently happening on master branch.


flake8...................................................................Failed
- hook id: flake8
- exit code: 1

miio/devtools/pcapparser.py:54:13: B036 Don't except `BaseException` unless you plan to re-raise it.
miio/integrations/lumi/gateway/alarm.py:97:13: B038 editing a loop's mutable iterable often leads to unexpected results/bugs
miio/integrations/lumi/gateway/devices/subdevice.py:334:13: B038 editing a loop's mutable iterable often leads to unexpected results/bugs```
codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4354615) 81.41% compared to head (bfe8065) 81.41%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1891 +/- ## ======================================= Coverage 81.41% 81.41% ======================================= Files 193 193 Lines 18564 18565 +1 Branches 4024 4024 ======================================= + Hits 15113 15114 +1 Misses 3170 3170 Partials 281 281 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.