search

rytilahti / python-miio

Python library & console tool for controlling Xiaomi smart appliances
https://python-miio.readthedocs.io
GNU General Public License v3.0
3.52k stars 542 forks source link

Fix genericmiot status to query all readable properties #1898

Closed rytilahti closed 4 months ago

rytilahti commented 4 months ago

Also, optimize future status queries a bit by constructing the status query already during the initialization phase.

Fixes a regression caused by #1871, the genericmiot requires deliberately some tests to avoid such, but it's better to have basic functionalities working on master so I'll merge this asap.

codecov[bot] commented 4 months ago

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (4354615) 81.41% compared to head (8126bf6) 81.47%. Report is 1 commits behind head on master.

Files Patch % Lines
miio/integrations/genericmiot/genericmiot.py 20.00% 8 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1898 +/- ## ========================================== + Coverage 81.41% 81.47% +0.06% ========================================== Files 193 193 Lines 18564 18549 -15 Branches 4024 4025 +1 ========================================== - Hits 15113 15112 -1 + Misses 3170 3163 -7 + Partials 281 274 -7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.