rytilahti / python-miio

Python library & console tool for controlling Xiaomi smart appliances
https://python-miio.readthedocs.io
GNU General Public License v3.0
3.52k stars 542 forks source link

Roborock: various improvements to exposed sensors #1914

Closed SLaks closed 3 months ago

SLaks commented 3 months ago
codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 81.41%. Comparing base (8230bd4) to head (c03410a).

Files Patch % Lines
...o/integrations/roborock/vacuum/vacuumcontainers.py 84.61% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1914 +/- ## ========================================== - Coverage 81.42% 81.41% -0.01% ========================================== Files 193 193 Lines 18628 18636 +8 Branches 4041 4045 +4 ========================================== + Hits 15167 15173 +6 - Misses 3179 3180 +1 - Partials 282 283 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

SLaks commented 3 months ago

I marked this as draft because I couldn't test it due to https://github.com/rytilahti/homeassistant-xiaomi-ng/issues/1.

Feel free to merge it; I may send followup PRs after https://github.com/rytilahti/python-miio/pull/1916 merges to fix other issues or add other features (eg, I plan to add a sensor for WiFi signal strength).

SLaks commented 3 months ago

Update: I verified that the map dropdown works correctly. However, it resets to the first map in the list (which, incidentally, is the map the robot is physically in) after 10 seconds or so.

SLaks commented 3 months ago

I pushed a WiFi strength sensor.

This is everything I wanted to add at the moment; I may send followups if I discover more issues

rytilahti commented 3 months ago

Thanks! I updated the title & description to be a bit more descriptive for the git logs, I hope that's fine with you.

SLaks commented 3 months ago

Of course

Thanks!

On Tue, Mar 19, 2024, 9:16 PM Teemu R. @.***> wrote:

Merged #1914 https://github.com/rytilahti/python-miio/pull/1914 into master.

— Reply to this email directly, view it on GitHub https://github.com/rytilahti/python-miio/pull/1914#event-12178283390, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACMUJSOKJF3H5P6G6ILQH3YZDPOPAVCNFSM6AAAAABE2QB65OVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSGE3TQMRYGMZTSMA . You are receiving this because you were mentioned.Message ID: @.***>