Closed SLaks closed 3 months ago
Attention: Patch coverage is 87.50000%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 81.41%. Comparing base (
8230bd4
) to head (c03410a
).
Files | Patch % | Lines |
---|---|---|
...o/integrations/roborock/vacuum/vacuumcontainers.py | 84.61% | 1 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I marked this as draft because I couldn't test it due to https://github.com/rytilahti/homeassistant-xiaomi-ng/issues/1.
Feel free to merge it; I may send followup PRs after https://github.com/rytilahti/python-miio/pull/1916 merges to fix other issues or add other features (eg, I plan to add a sensor for WiFi signal strength).
Update: I verified that the map dropdown works correctly. However, it resets to the first map in the list (which, incidentally, is the map the robot is physically in) after 10 seconds or so.
I pushed a WiFi strength sensor.
This is everything I wanted to add at the moment; I may send followups if I discover more issues
Thanks! I updated the title & description to be a bit more descriptive for the git logs, I hope that's fine with you.
Of course
Thanks!
On Tue, Mar 19, 2024, 9:16 PM Teemu R. @.***> wrote:
Merged #1914 https://github.com/rytilahti/python-miio/pull/1914 into master.
— Reply to this email directly, view it on GitHub https://github.com/rytilahti/python-miio/pull/1914#event-12178283390, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACMUJSOKJF3H5P6G6ILQH3YZDPOPAVCNFSM6AAAAABE2QB65OVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSGE3TQMRYGMZTSMA . You are receiving this because you were mentioned.Message ID: @.***>
clean_percent
options
,device_class
,suggested_display_precision
on specific sensors for better homeassistant integration