search

rytilahti / python-miio

Python library & console tool for controlling Xiaomi smart appliances
https://python-miio.readthedocs.io
GNU General Public License v3.0
3.52k stars 542 forks source link

add xiaomi.airp.va2b support #1940

Open dsh0416 opened 3 weeks ago

dsh0416 commented 3 weeks ago

Meanwhile, for xiaomi.airp.va2b, it would cause {'code': -9999, 'message': 'user ack timeout'} when querying status, and I am still figuring why.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.67%. Comparing base (8643a57) to head (6cf9755). Report is 4 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1940 +/- ## ========================================== + Coverage 81.41% 81.67% +0.25% ========================================== Files 193 197 +4 Lines 18636 19176 +540 Branches 4045 4208 +163 ========================================== + Hits 15173 15662 +489 - Misses 3180 3220 +40 - Partials 283 294 +11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dsh0416 commented 3 weeks ago

By randomly comment out some of the properties make the fetching process works. It might be caused by an incorrect Message.parse process in miioprotocol.py.

dsh0416 commented 3 weeks ago

By randomly comment out some of the properties make the fetching process works. It might be caused by an incorrect Message.parse process in miioprotocol.py.

Problem confirmed. It looks like the default max_properties is too large for xiaomi.airp.va2b.

dsh0416 commented 3 weeks ago

I don't think I would be able to fix the readthedocs CI properly, so that this commit is now ready for review.

dsh0416 commented 1 week ago

reverted. Thank you for reviewing, and I may move the comments changes to a further PR. @rytilahti