search

ryu1kn / csv-writer

Convert objects/arrays into a CSV string or write them into a CSV file
https://www.npmjs.com/package/csv-writer
MIT License
246 stars 39 forks source link

Missing LICENSE file #31

Closed marcosd3souza closed 4 years ago

marcosd3souza commented 4 years ago

Please include MIT LICENSE on version (1.5.0) repository

ryu1kn commented 4 years ago

Hi @marcosd3souza , it's MIT.

dup #19

marcosd3souza commented 4 years ago

Hi @marcosd3souza , it's MIT.

dup #19

Ok, but where is the LICENSE file? The file location on repository it's important to report dependency use.

ryu1kn commented 4 years ago

Well, as I commented in #19, the license is specified in package.json and that's how we can clarify the license of a npm module. Can you not report with that context?

https://github.com/ryu1kn/csv-writer/blob/1c71214829e4324e1a45e27229d5fd1328dd6127/package.json#L26

cf. https://docs.npmjs.com/files/package.json#license

image

WorldMaker commented 4 years ago

You would see fewer of these questions if you added a LICENSE file because that's how GitHub itself reports LICENSE information, lighting up the license indicator directly on the GitHub repository page. Conveniently, if you try to add a LICENSE file directly in the GitHub browser it will show a button to Use a LICENSE Template and you can just select MIT and GitHub will mostly fill in the rest for you.

https://docs.github.com/en/github/building-a-strong-community/adding-a-license-to-a-repository

ryu1kn commented 4 years ago

Thanks @WorldMaker , that's a better idea and your explanation made it so easy for me! 👍