search

ryu1kn / vscode-text-marker

Visual Studio Code Extension. Select text in your code and mark all matches. The marking colour is configurable
https://marketplace.visualstudio.com/items?itemName=ryu1kn.text-marker
MIT License
87 stars 17 forks source link

Cosmetic improvements #15

Closed Kronuz closed 6 years ago

Kronuz commented 6 years ago
ryu1kn commented 6 years ago

@Kronuz Apologies for my slow response and thank you for the PR!

It's great, the characters under highlights are much more visible now. I'm happy to merge this in but I'm thinking to introduce a flag to enable this feature as it overwrites the colour given by the syntax highlighting, and some people might want to see the original colour :wink:

Kronuz commented 6 years ago

@ryu1kn I have since updated a couple other things and fixed a bug, I’ll add another pull request to fix that.

ryu1kn commented 6 years ago

Cool thanks @Kronuz 👍It hasn't been released yet, so take your time 😉

ryu1kn commented 6 years ago

Hi @Kronuz , I need to make a change on master; so I've created a branch highcontrast-text-colour that is equivalent to the master and rewound the master back to the state before merging your changes. You can create a PR against highcontrast-text-colour branch when it's ready. Thanks :wink:

Kronuz commented 6 years ago

The bug was already fixed in the pull request, I just didn't think it was... the other thing I changed was using color-name package instead of declaring the color names ourselves. I'm opening a new pull request for that one now :)

ryu1kn commented 6 years ago

Sorry the slow response. I've just published it as v1.2.0! Thanks for your help :wink: