search

ryu1kn / vscode-text-marker

Visual Studio Code Extension. Select text in your code and mark all matches. The marking colour is configurable
https://marketplace.visualstudio.com/items?itemName=ryu1kn.text-marker
MIT License
87 stars 17 forks source link

Toggle does not work well when it is already marked and selected #18

Closed jaaviercr closed 6 years ago

jaaviercr commented 6 years ago

Toggle does not work well when it is already marked and selected, steps to reproduce it:

  1. Select some text
  2. Toogle highlight
  3. Without loosing selection, toogle highlight again

I think that the correct behaviour would be that the highlight should be cleared but now it does nothing.

Thank you and congratulations for this cool tool 🥇

ryu1kn commented 6 years ago

Thanks @jaaviercr , I could reproduce it. Thanks for reporting it!!

Text Marker: v1.1.0 VS Code: v1.24.0 macOS: 10.13.5

ryan-surrey commented 6 years ago

Any idea of when a fix for this will land?

I've just come across this extension, firstly let me state that its great, i love it, apart from this defect which forces me to have two key bindings to be able to quickly toggle highlighting.

Using v1.3.0

ryu1kn commented 6 years ago

Thanks @ryan-surrey for the encouraging comment, also the information how it's affecting your workflow. I'm a bit busy at the moment but hope that I can look into it this weekend 👍

ryu1kn commented 6 years ago

The fix released as v1.3.1. @jaaviercr @ryan-surrey it would be great if you could confirm it's working fine for you 😉

jaaviercr commented 6 years ago

@ryu1kn It works perfect now! Thank you very much! 😄

ryu1kn commented 6 years ago

Cool! Thanks for confirming @jaaviercr 👍

ryan-surrey commented 6 years ago

@ryu1kn, just picked up the latest version, thanks for the fix, its working great!

ryu1kn commented 6 years ago

Thanks for confirming it @ryan-surrey ! 👍 (Sorry, seems somehow I missed the notification...)