Suggestion: Don't mark when text selected

ryu1kn / vscode-text-marker

Visual Studio Code Extension. Select text in your code and mark all matches. The marking colour is configurable

https://marketplace.visualstudio.com/items?itemName=ryu1kn.text-marker

MIT License

87 stars 17 forks source link

Suggestion: Don't mark when text selected #2

Closed Bill-Stewart closed 6 years ago

Bill-Stewart commented 7 years ago

This extension is useful! If I select something and mark, then go back and select it again, I can't see the selection. Is there a way to make the selection visible even though something is marked?

ryu1kn commented 7 years ago

Thanks for the suggestion. It looks like TextMarkers highlight is stronger than editor's text selection highlight.

It's nice both a selection and a marker are recognisable at the same time though I'm not too sure if this is a big concern.

Anyway, possible options I can think of right now are:

Make the way to mark texts configurable. Right now decoration is always by changing background-color
- cons: Only solves the problem for users ok with using non- background-color change highlight
Temporarily unmark a part of text that is already marked
- cons: Not too sure how it goes. Logic will become complex.

Bill-Stewart commented 7 years ago

Yes, it is low priority and not a very big issue.

ryu1kn commented 6 years ago

I recently noticed if you specify an opacity when you set a colour for highlight (like rgba(0, 0, 255, 0.3)), then selection will become more visible. But with this way, you've got to give opacity for all colours.

With the configuration introduced in #23 , you can give a default opacity and it will be used unless you specify an opacity for a colour! If you're still using the extension, please try it out :wink: