Add ability to save highlight color

ryu1kn / vscode-text-marker

Visual Studio Code Extension. Select text in your code and mark all matches. The marking colour is configurable

https://marketplace.visualstudio.com/items?itemName=ryu1kn.text-marker

MIT License

87 stars 17 forks source link

Add ability to save highlight color #28

Closed BoruiGu closed 5 years ago

BoruiGu commented 5 years ago

Implements https://github.com/ryu1kn/vscode-text-marker/issues/24

ryu1kn commented 5 years ago

Hello @BoruiGu , thank you very much for the PR and sorry for my slow response!

The code change looks ok to me. Behaviour-wise, I was at first surprised when it added colours for the highlights that existed before I overwrote the highlights. But probably it's fine and desirable...

I'm going to merge your change 👍

ryu1kn commented 5 years ago

Released as v1.10.0 🎉 Thanks again for your contribution!