highlight entire line - Githubissues

ryu1kn / vscode-text-marker

Visual Studio Code Extension. Select text in your code and mark all matches. The marking colour is configurable

https://marketplace.visualstudio.com/items?itemName=ryu1kn.text-marker

MIT License

87 stars 17 forks source link

highlight entire line #43

Open ozskywalker opened 4 years ago

ozskywalker commented 4 years ago

I've been using this for reading through new codebases and trying to determine where a certain function is used as I'm going back and forth during code review.

Is it possible to have a feature where it highlights the entire line that my selection is found?

ryu1kn commented 4 years ago

Hi @ozskywalker , would using Highlight Text Using Regex command work for you? Using the regex pattern like: .*certain_function.*

ozskywalker commented 4 years ago

That's an OK workaround for now, but having to type in regex is time-consuming.

What I really want to be able to do, is when I select or double-click a phrase, my next action is either to:

select the "Highlight Text and Entire Line" menu option
or, enable an option that when "Highlight Text" is selected, it will highlight the entire line instead of just the selection

This is so the phrase I'm looking for as I review a codebase stands out more, is easier for my eyes to scan, and quicker for me to react to reviewing portions of the codebase.

ryu1kn commented 4 years ago

It can be particularly helpful if a line is very long and doesn’t fit in the window width.

Exploring the idea. Some issues i can think of:

We may want to emphasise the matching text on the highlighted line especially when the line is very long too.
It can be difficult to see what’s going on if multiple patterns highlight the same line. The same problem exists with highlighting only the match text, but this would happen more often.

ozskywalker commented 4 years ago

The last issue yes in theory, but I think the frequency of that would be very low in reality. You could also counter by applying full line highlights last and override any highlights that are there (easy to say of course).