ryu1kn / vscode-text-marker

Visual Studio Code Extension. Select text in your code and mark all matches. The marking colour is configurable
https://marketplace.visualstudio.com/items?itemName=ryu1kn.text-marker
MIT License
87 stars 17 forks source link

marker are not save ? #5

Closed jonlepage closed 6 years ago

jonlepage commented 7 years ago

Ryuichi Inagaki 14 hours ago

Happy New Year to you and thank you for your plugin. I'd like to use your plugin to improve my js codes in a game engine developer context. I would like to know, if will be possible do similar highlight of what [notepad++] allowed. Here is a rough example to highlight and separate some line of code. in [notepad++] Your plugin is ideal for me, but highlight does save when closed? http://imgbox.com/ONUBaWcn

I would like to be able to highlight with a white background color and saved. :) I'm new to VBC and I love it, I only regret marker layout, but your plugin will seem able to offer this context Thank you friend

ryu1kn commented 7 years ago

Thanks for your suggestion. The image was very helpful 👍

Let me first explain what are my main motivations for developing this extension. They are:

Now, It seems like what you want to achieve is to always emphasise certain statements (like console.log debug statements) or comments that start with certain sequence (like ##).

Adding the save functionality to the extension would be useful so that I can close the editor and resume the log reading later. Supporting regex to highlight would also be great. It allows me to highlight not only the texts beginning with ## but also texts with slight variation such as date string. I'll think supporting it.

But perhaps, as what you want is more like customisation of your syntax highlighting, if you're only thinking about js, it might be faster if you write your own js syntax highlighting and replace the default one. cf. Adding Language Colorization 😉

jonlepage commented 7 years ago

comments that start with certain sequence (like ##).

Adding the save functionality to the extension

I was afraid, not to be understood but you seem to have all understood !! for the Adding Language Colorization, I am an elder of (notepad ++). At the moment I still find it super complicate the methods of custom syntax Colorization, . But, I hope a pro like you, is able to help me with your plugin. For now, I still find super complicating methods of personal syntax on VBC. I will be very happy with your plugin, if we can highlight a few lines of code and save it.

Example: Key: CTRL + H [set highlight code select] , and CTRL + ALT + H [switch++ background highlight color].

Thank you very much friend, for your attention, I remain alert of your updates. Your plugin is really helpfull for me . If my request does not seem to use you. It does not matter, I was simply suggestion hoping for a positive answer.

have nice day

thomasf commented 7 years ago

It would maybe be a good thing to be able to add highlights to user or workspace settings to manually persist some hl's.

ryu1kn commented 7 years ago

@thomasf Sorry, somehow I missed your comment...

Cool, seems we can use WorkspaceConfiguration#update introduced in code v1.6

ryu1kn commented 7 years ago

I use this issue for persisting highlights. Supporting regular expressions will be done in https://github.com/ryu1kn/vscode-text-marker/issues/8

jonlepage commented 7 years ago

yes it work thank

Otiel commented 6 years ago

Any progress on the save highlights functionality? Are you still considering adding it or has it been dropped?

ryu1kn commented 6 years ago

Not dropped. I think this feature is useful. I just haven't got enough time to work on this at the moment

ryu1kn commented 6 years ago

Things to consider

On saving highlights

On restoring highlights

ryu1kn commented 6 years ago

Let's get this feature out with the simplest functionality. After getting feedback, we'll decide how to evolve it from there.

mjunaidch commented 6 years ago

Hello,

This is great plugin . I am waiting for Save Highlight feature. I think it comes soon... @ryu1kn

Regards

ryu1kn commented 6 years ago

Hi @mjunaidch . I started working on Dec but got distracted by other stuff. I should resume the work, thanks for reminding me 😄

ryu1kn commented 6 years ago

Finally published as v0.11.0! 🎉

Sorry that it took me a year. @djmisterjon @Otiel @thomasf , if you're still using TextMarker, please try it out 😉

Otiel commented 6 years ago

It works fine according to my few tests. Thanks for your work! ❤️

At first I thought it didn't work because I didn't think I was supposed to call "Save All Highlights" before restarting VS code. Hence #10.

ryu1kn commented 6 years ago

Cool, thanks for testing it out @Otiel !