ryu1kn / vscode-text-marker

Visual Studio Code Extension. Select text in your code and mark all matches. The marking colour is configurable
https://marketplace.visualstudio.com/items?itemName=ryu1kn.text-marker
MIT License
87 stars 17 forks source link

Support for jupyter notebooks (right click) #66

Open codeblazar opened 3 years ago

codeblazar commented 3 years ago

Would be great to have support for jupyter notebooks with the text highlights provided using right-click. Currently works fine through the Command Palette

codeblazar commented 3 years ago

I extract hundreds of python snippets from an exam system, convert into jupyter (p2j) and then mark. The exam system doesn't support coding (no syntax highlighting, no indentation and no running code). Having right-click would be great, although access through the Command Palette is workable. Thanks for this plugin.

ryu1kn commented 3 years ago

Hi @Nezakka , thanks for the suggestion. I don't quite get the request. Are you trying to use Text Marker in VS Code's jupyter notebook support? But there text marker is not in the right click menu but you can still use it if you execute TextMarker: ... commands from the command palette?

codeblazar commented 3 years ago

Hi 🙂

Exactly.

Maybe some screen shots will help.

Below is right click on the 100. The options for your highlight do not appear, however ...

[cid:4a33f4d2-de13-43f8-bbe6-86b4d14254f4]

I am still able to access and use the functionality from the command palette.

[cid:a5472615-259f-497d-a948-157981e5f324]

Hope that helps.

Pete.


From: Ryuichi Inagaki @.> Sent: 26 August 2021 18:28 To: ryu1kn/vscode-text-marker @.> Cc: Pete @.>; Mention @.> Subject: Re: [ryu1kn/vscode-text-marker] Support for jupyter notebooks (right click) (#66)

Hi @Nezakkahttps://github.com/Nezakka , thanks for the suggestion. I don't quite get the request. Are you trying to use Text Marker in VS Code's jupyter notebook supporthttps://code.visualstudio.com/docs/datascience/jupyter-notebooks? But there text marker is not in the right click menu but you can still use it if you execute TextMarker: ... commands from the command palette?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/ryu1kn/vscode-text-marker/issues/66#issuecomment-906284446, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQAVWAOZ3DKFXFBU2SS52LTT6YJNNANCNFSM5C2KND4Q. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email.

ryu1kn commented 3 years ago

Cool, thanks Pete for confirming it. I got it 👌

codeblazar commented 3 years ago

No worries. Great little tool by the way. Love the regex the most. Tools like this make VSC a delight. Thank you for writing it. On 26 Aug 2021, 7:06 PM +0800, Ryuichi Inagaki @.***>, wrote:

Cool, thanks Pete for confirming it. I got it 👌 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

codeblazar commented 3 years ago

Hi,

I've just realised (I'm slow) that the highlights work across open documents. So you can highlight in say script.py and it will be highlighted in script.ipynb. In this case, maybe my suggestion is not required - there is a very simple work around.

Thanks again,

Pete.


From: Ryuichi Inagaki @.> Sent: 26 August 2021 19:06 To: ryu1kn/vscode-text-marker @.> Cc: Pete @.>; Mention @.> Subject: Re: [ryu1kn/vscode-text-marker] Support for jupyter notebooks (right click) (#66)

Cool, thanks Pete for confirming it. I got it 👌

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/ryu1kn/vscode-text-marker/issues/66#issuecomment-906307936, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQAVWAOWHMTKIU5GGZ5PB23T6YN2FANCNFSM5C2KND4Q. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email.