ryujinx-mirror / ryujinx

Hard-fork of the Ryujinx project
MIT License
2.1k stars 534 forks source link

[Bug]Controller Input Configuration does not work properly #86

Open marcosfa00 opened 2 weeks ago

marcosfa00 commented 2 weeks ago

Description of the issue

Firmware Version 19.0.0.

Currently, when you connect the controller and play any game, it works correctly, regardless of the number of controllers you connect. The issue/bug arises when you try to change the button mappings.

As we know, the layout of Nintendo controllers is different from that of XBOX or PS4.

Ideally, you should be able to edit the key mapping so that it matches the controller layout, ensuring that A corresponds to A on the XBOX controller, B to B, and so on for all buttons.

The problem is that the changes are not saved correctly. Not only are they not saved correctly, but even if you have the configuration set correctly and save a profile with this setup, if you later play with a different controller than the one you were previously using, the configuration will not select any controller when loaded.

For example, if you want to play Mario Kart with two players using XBOX controllers, you configure the controllers and save the profile with this configuration (if it saves at all, as it may take 30 tries to get it to work, regardless of how many times you press save or apply).

If afterward, you want to play the same game with different controllers, you will have to start from scratch because the saved configuration in a profile does not work.

Another common issue with controllers is the following situation:

You have your profile saved and manage to get it working correctly, but you go to a friend’s house and want to play Mario Kart, this time with four configured controllers. After several minutes, you manage to get it working and enjoy Mario Kart together. Now, when you return home and want to play with your usual two controllers instead of the four used at your friend’s house, the saved configuration will not work.

Additionally, if you are playing a multiplayer game and a controller disconnects, runs out of battery, or any other issue arises, the game crashes automatically. You will need to close the emulator and reopen it. And guess what? You will have to configure the controllers again.

NOTE: I used a simple example with Mario Kart, but this issue occurs with absolutely every game. This is an emulator flaw, not specific to any particular game.

Reproduction steps

The issue occurs every time you try to connect a new controller/input device to the computer and attempt to configure the key mapping.

Log file

Ryujinx_1.1.1388_2024-11-05_22-42-24.log Ryujinx_1.1.1388_2024-11-05_23-42-10.log Ryujinx_1.1.1388_2024-11-05_23-44-40.log

OS

Mac OSSequoia 15,1

Ryujinx version (revision hash)

1.1.1388

Game version

3.0.1

CPU

M1 MAX

GPU

Apple M1 MAX

RAM

32

List of applied mods

No response

Additional context?

No response

marcosfa00 commented 2 weeks ago

OS

Mac OSSequoia 15.1

Ryujinx version (revision hash)

1.1.1388

It Also happens in Ryujinx Version 1.1.1403