search

ryukinix / mal

MAL: A MyAnimeList Command Line Interface [BROKEN: BLAME MyAnimeList]
https://mal.readthedocs.io
Other
109 stars 9 forks source link

add tests to cover api retreive anime list #68

Closed xxami closed 6 years ago

xxami commented 6 years ago

currently working on adding manga support to api and wanted some tests first to work from. i saw there is an issue about this but doesn't seem to be progress?

only covers list api happy path right now; i wanted to open pr early before i write lots of code that's not going to be merged :P

so, let me know if the approach is okay and i could continue to add more full coverage to the api

https://travis-ci.org/xxami/mal/jobs/291137211

ryukinix commented 6 years ago

Finallyy the tests!!!!!!!!! oh man, this so good. I'm really happy about that!

ryukinix commented 6 years ago

That are really simple tests, but thank you to providing that. I've been procrastinating that for a lot of time, as you probably saw.

I only need that a __main__.py file be added to I be able to run coverage tool easily as coverage run tests. I already wrote a file, if this PR was marked as editable, I will send a new commit to your branch.

ryukinix commented 6 years ago

Seems I don't have permissions to make change on your repo. That's fine.

Please, make that steps on your own fork local copy:

git checkout feature/api-unit-tests
git fetch https://github.com/ryukinix/mal.git
git cherry-pick 7dc33b0f5e
git push -u origin feature/api-unit-tests
xxami commented 6 years ago

have added that :) i think the ci failure on this change is a mistake, it's passing on mine and i think it should pass on re-run

ryukinix commented 6 years ago

@xxami yes, clearly travis problem. I restarted the job.

ryukinix commented 6 years ago

LGTM. Merging