ryukinix / mal

MAL: A MyAnimeList Command Line Interface [BROKEN: BLAME MyAnimeList]
https://mal.readthedocs.io
Other
109 stars 9 forks source link

[cli] translate anime_regex to anime_title on search command #89

Closed ryukinix closed 6 years ago

ryukinix commented 6 years ago

This would avoid confusion since global search command doesn't use regex at all! This just happened because the old search command was renamed to filter, which use regex to match on the local userlist.

Since we search is done by the REST API of mal, and I don't have intention to do horrible web scrap stuff on something like mal, this is the thing.

Being explicit it's important, sorry for the users that though that would be possible search GLOBALLY for animes on MyAnimeList. This will not gonna happen.

Closes #88

codecov-io commented 6 years ago

Codecov Report

Merging #89 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #89   +/-   ##
======================================
  Coverage    83.7%   83.7%           
======================================
  Files           8       8           
  Lines         362     362           
======================================
  Hits          303     303           
  Misses         59      59

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a56474f...4a0bb95. Read the comment docs.