ryurko / fcscrapR

R package to scrape soccer commentary and statistics from ESPN
28 stars 11 forks source link

Update Scrape Scoreboard IDs function #5

Closed meysubb closed 6 years ago

meysubb commented 6 years ago

Here's what I've done 1) league_df <- League name to HREF reference (The way this was obtained is in extract_league_df.R) 2) updated scrape_scoreboard_id

Note the scrape_scoreboard_id function needs a little cleaning up. it scrapes not only the given date but the ticker at the top too (i.e the current date).

ryurko commented 6 years ago

Just implemented your code in a slightly different way so I won't accept the pull request - but added you as a package author, thanks!

meysubb commented 5 years ago

For some reason, this never popped up in my notis till now. Thanks!