search

ryurko / nflscrapR-data

Data files (.csv) accessed with nflscrapR and summarized at the player-level
https://ryurko.github.io/nflscrapR-data/
373 stars 204 forks source link

Game player stats - proposed changes #2

Open sansbacon opened 7 years ago

sansbacon commented 7 years ago

I think the game player stats files would be more useful if you had a field for season and week. This would allow you to do lead/lag and other window functions.

Also, there are some NaN, Inf, and '-' values in certain fields. Do you think it would be better to change those to empty strings? In the attached file, I used the foreign data wrapper in postgresql to join the csv file with my existing tables to add in the season and week and I had to remove all of those values for the process to work.

game_passing_df.csv.tar.gz

Thanks! Eric

ryurko commented 7 years ago

Great suggestion - will work on it