ryuslash / mode-icons

Show icons instead of mode names
http://projects.ryuslash.org/mode-icons/
156 stars 28 forks source link

Inconsistent icon sizes on hidpi screens #35

Open calliecameron opened 8 years ago

calliecameron commented 8 years ago

Hi,

Using Emacs 24.5.1 on Linux Mint 18 with HiDPI scaling turned on, some icons are very small:

image

The text mode and autorevert icons are normal sized, but the python and terminal icons are small. I think this might have something to do with using icons from fonts vs. XPMs; I have FontAwesome, mfizz and IcoMoon installed on my system.

mattfidler commented 8 years ago

Yes. This is because of the difference between pixel icons vs fonts.

Is your emacs compiled with Imagemagick support? In theory, emacs should resize the images if you do...

mattfidler commented 8 years ago

Same size icons could also be supported if:

Or,

calliecameron commented 8 years ago

Is your emacs compiled with Imagemagick support?

I think so - at least, imagemagick-types exists and returns a big list of file types. Are there any particular variables I would need to set to make image resizing work? My emacs can also open svgs, but I'm not sure if that's a default feature or something I had to enable at compile time.

mattfidler commented 7 years ago

It seems it is supported on your system. Perhaps you can add some amount to the height to have the images resized appropriately...? I have added an option mode-icons-line-height-adjust to allow manual adjustment...

calliecameron commented 7 years ago

Finally had a chance to try this, but it doesn't seem to be working. The small icons are still the same size no matter what I set mode-icons-line-height-adjust to.

In case it was a conflict with something else in my configuration, I tried it with a blank .emacs, just installed the package and then did:

(setq mode-icons-line-height-adjust 20) ; or any other number
(mode-icons-mode)

Is that right?

mattfidler commented 7 years ago

In theory it should work, but obviously it doesn't. I'm not sure why. It may work in a standard buffer, but not in the mode line.

To1ne commented 7 years ago

Having decent support for HiDPI would be a really big plus.

How about creating @2x versions of the icons?