search

ryuta46 / vscode-multi-command

Visual Studio Code Plugin named multi-command
MIT License
229 stars 14 forks source link

Extension kind is not defined and always runs remotely #41

Closed leighmcculloch closed 3 years ago

leighmcculloch commented 3 years ago

This vscode extension doesn't specify the extensionKind field in package.json and as such it runs as a workspace extension. Workspace extensions will always run remotely when VSCode is using the remote containers/ssh extension and running the VSCode server inside a remote container/instance.

I think it is unnecessary for the extension to only run remotely, or rather, it could run either remotely or locally.

See this article for more details: https://code.visualstudio.com/api/advanced-topics/remote-extensions

To have it run locally or remotely the extensionKind property can be added to package.json with value ["ui", "workspace"].

leighmcculloch commented 3 years ago

I forgot to mention, the main side-effect of only running remotely is that when using VSCode and starting a remote container the extension will be disabled until the user manually installs the extension in the container. If the extension is configured to run with both ui and workspace, it will continue running locally when a container is started but the user can choose to install it in the container if they wished.

ryuta46 commented 3 years ago

I didn't care extensionKind field. I'll check the article you mentioned. Thank you.

ryuta46 commented 3 years ago

Thank you for the PR. I released this change as v1.5.1. Please reopen this issue if you have any problem about this change.

Thanks.