search

ryuta46 / vscode-multi-command

Visual Studio Code Plugin named multi-command
MIT License
229 stars 14 forks source link

Simplify implementation #7

Closed krzkaczor closed 5 years ago

krzkaczor commented 6 years ago

I have few suggestions after looking at code:

  1. https://github.com/ryuta46/vscode-multi-command/blob/master/src/extension.ts#L48 is there any reason why is this so complicated? Normal for of loop with await inside will result in similiar sequential execution.

  2. From what I see vsc supports modern JS so transpilation is not required. (await async works natively)

ryuta46 commented 5 years ago

Thank you for your advise! I was a newbie of TypeScript when I first wrote this plugin. I'll check the implementation.