search

rywhale / kiwisR

Provides a simplified method for bringing tidy data into R from KISTERS WISKI databases via KiWIS API.
Other
12 stars 2 forks source link

Unit test issue related to testthat 3.0 release #16

Open rywhale opened 4 years ago

rywhale commented 4 years ago

Error in tests for ki_station_list related to testthat 3.0 release. From check in email:

----FAILURE (test_ki_station_list.R:71:3): ki_station_list accepts custom return
`stn_cust_retr` not equal to `stn_cust_retr2`
Component "station_id": 76 string mismatches
Component "station_no": 76 string mismatches
dimfalk commented 2 years ago

Hi, I was messing around with testthat 3.0 lately and thought I'd have a look into this issue here.

In order to activate v3.0, Config/testthat/edition: 3 needs to be added to DESCRIPTION if I'm not mistaken.

As a result, devtools::test() returns the following:

Duration: 62.8 s

[ FAIL 0 | WARN 5 | SKIP 0 | PASS 55 ]

Warnings are limited to context() was deprecated in the 3rd edition - but I was not able to reproduce the bug mentioned above in test_ki_station_list.R.

Is this issue still relevant?

Thanks!