ryyanmapes / minecart-mod

An open-source Minecraft mod for 1.16.5 adding new options for rail networks.
https://www.curseforge.com/minecraft/mc-mods/more-minecarts
Other
14 stars 15 forks source link

1.19 port #67

Closed raqbit closed 2 years ago

raqbit commented 2 years ago

The target branch for this pull request should probably be aimed at a different branch, but the main branch is not-up-to-date and there is no 1.19 branch yet.

Changes

Functional changes

Removes glass cactus spawn rate config value. Registration can no longer depend on configuration values. Users which want to change the spawn rate have to overwrite the placement rarity with a datapack, as follows:

moreminecarts/worldgen/placed_feature/glass_cactus_patch.json

{
  "feature": "moreminecarts:glass_cactus_patch",
  "placement": [
    {
      "type": "minecraft:rarity_filter",
      "chance": <value>
    },
    {
      "type": "minecraft:in_square"
    },
    {
      "type": "minecraft:heightmap",
      "heightmap": "MOTION_BLOCKING"
    },
    {
      "type": "minecraft:biome"
    }
  ]
}
ryyanmapes commented 2 years ago

Wow! This is unexpected! There's a few tiny things I need to fix still, but this is really comprehensive. I will merge this later today. Thank you so much for the contribution!

raqbit commented 2 years ago

Wow! This is unexpected! There's a few tiny things I need to fix still, but this is really comprehensive. I will merge this later today. Thank you so much for the contribution!

Cool! I must say I haven't been able to test every single feature of the mod, so an extra pair of eyes to look everything over / test it would be nice.

ryyanmapes commented 2 years ago

The only thing I found during testing is that chunk loaders seem to have broke again. I'll fix that tonight; I believe it's just that the previous forge version had a flipped boolean issue when setting chunks to keep loaded that probably got fixed.