Prevent client keybind register event from firing on server after Forge update to 41.0.98

ryyanmapes / minecart-mod

An open-source Minecraft mod for 1.16.5 adding new options for rail networks.

https://www.curseforge.com/minecraft/mc-mods/more-minecarts

Other

14 stars 15 forks source link

Prevent client keybind register event from firing on server after Forge update to 41.0.98 #72

Closed zach2039 closed 2 years ago

zach2039 commented 2 years ago

Fixes an issue with keybind event firing on servers, introduced in pull #71.

Tested on dedicated server and client.

ryyanmapes commented 2 years ago

Good catch! I haven't gotten around to a comprehensive test of this new version, but I'll let you know if anything else comes up when I do.

ryyanmapes commented 2 years ago

It looks like the keybinds for the piston pushcart are broken in single player now.

zach2039 commented 2 years ago

It looks like the keybinds for the piston pushcart are broken in single player now.

Let me try to see if I can do similar in a new PR for the piston pushcart. Have not used them much in private server with friends, so might have missed that issue.