ryzom / ryzomcore

Ryzom Core is the open-source project related to the Ryzom game. This community repository is synchronized with the Ryzom Forge repository, based on the Core branch.
https://wiki.ryzom.dev
GNU Affero General Public License v3.0
331 stars 89 forks source link

In game support chat connexion don't work as expected #114

Closed ryzom-pipeline closed 9 years ago

ryzom-pipeline commented 10 years ago

Original report by Guillaume DUPUY (Bitbucket: [Guillaume DUPUY](https://bitbucket.org/Guillaume DUPUY), ).


Since the server merge, you can connect to the support chat (ceb) using the client only if your account is on the french community. The involved code is in code/ryzom/client/src/interface_v3/interface_manager.cpp, line 3254 to 3285 ; the problem is around the switch :

#!c++

    extern TSessionId HighestMainlandSessionId;
    switch(HighestMainlandSessionId.asInt())
    {
    case 101: KlientChatPort = 6002; break; // fr
    case 102: KlientChatPort = 6003; break; // de
    case 103: KlientChatPort = 6001; break; // en
    case 301: KlientChatPort = 4000; break; // yubo
    default:
        if(!ClientCfg.KlientChatPort.empty())
            fromString(ClientCfg.KlientChatPort, KlientChatPort);
        break;
    }

The HighestMainlaindSessionId actually refers to the ShardId (i'm not totally sure though), and since there is only one shard now it doesn't work anymore. It could be based on the client language (although autorizing people to override this by using the client.cfg for example might be a good idea), and the hard code url might be removed and added as a client.cfg variable.

ryzom-pipeline commented 9 years ago

Original comment by Jan Boon (Bitbucket: [Jan Boon](https://bitbucket.org/Jan Boon), ).


Klients to be removed from Ryzom Core.

ryzom-pipeline commented 9 years ago

Original comment by Jan Boon (Bitbucket: [Jan Boon](https://bitbucket.org/Jan Boon), ).


Remove Yubo chat, ref #114

ryzom-pipeline commented 9 years ago

Original comment by Jan Boon (Bitbucket: [Jan Boon](https://bitbucket.org/Jan Boon), ).


Feature will be removed in 1.0, removal done in feature-remove-compatibility