ryzom / ryzomcore

Ryzom Core is the open-source project related to the Ryzom game. This community repository is synchronized with the Ryzom Forge repository, based on the Core branch.
https://wiki.ryzom.dev
GNU Affero General Public License v3.0
337 stars 90 forks source link

Compile failing under Ubuntu 13:10 now. #145

Closed ryzom-pipeline closed 10 years ago

ryzom-pipeline commented 10 years ago

Original report by Tierry Anthony (Bitbucket: Tissiwau, ).


Since the middle of March I have had a compiler failure associated with OpenGL. I am running with the nVidia 304 drivers, as provided by Ubuntu. I have check all libraries headers etc and can find nothing which would cause the error to occur now.

This is what I get during the nelgui build stage.

/opt/ryzom/code/nel/src/3d/driver/opengl/driver_opengl.cpp: In member function ‘virtual void NL3D::CDriverGL::setSwapVBLInterval(uint)’:

/opt/ryzom/code/nel/src/3d/driver/opengl/driver_opengl.cpp:2198:54: error: invalid operands of types ‘void’ and ‘int’ to binary ‘operator==’

res = nglXSwapIntervalEXT(_dpy, _win, interval) == 0;

I userstand what the problem is but I don't know why it is occurring now.

ryzom-pipeline commented 10 years ago

Original comment by Meelis Mägi (Bitbucket: [Meelis Mägi](https://bitbucket.org/Meelis Mägi), ).


The change occurred in 6019297a8af0

ryzom-pipeline commented 10 years ago

Original comment by Jorge Araya Navarro (Bitbucket: [Jorge Araya Navarro](https://bitbucket.org/Jorge Araya Navarro), ).


this happens too on Parabola GNU/Linux-libre!

ryzom-pipeline commented 10 years ago

Original comment by Cédric Ochs (Bitbucket: [Cédric OCHS](https://bitbucket.org/Cédric OCHS), ).


Hum, perhaps should we update docs, if you plan to use Ryzom Core to connect to official Ryzom servers, you should use "compatibility" branch and it has been fixed on it :)

See aa4173a

And I wasn't notified about this issue :(

ryzom-pipeline commented 10 years ago

Original comment by Cédric Ochs (Bitbucket: [Cédric OCHS](https://bitbucket.org/Cédric OCHS), ).


In fact, the problem was, we were previously redefining OpenGL prototype functions and at the moment I added glXSwapIntervalEXT call, the prototype was wrong in glxext.h... They fixed it later and as we are now using glxext.h directly, it created a wrong function call

ryzom-pipeline commented 10 years ago

Original comment by Tierry Anthony (Bitbucket: Tissiwau, ).


Thank you for the explanation. I had amended the code to exactly the change shown in aa4173a, as it happens. I was just confused as to why it had suddenly occured.

ryzom-pipeline commented 10 years ago

Original comment by Cédric Ochs (Bitbucket: [Cédric OCHS](https://bitbucket.org/Cédric OCHS), ).


You're welcome :)

Yes, I noticed that :) Btw I simplified things... I merged "compatibility" and "default" branches in both ways and I'll push next commits related to both branches in "default". So there should have only default -> compatiblity merges and if something breaks compatibility with official servers, we can commit the fix in compatiblity branch :)

It should be easier to manage like that :)

ryzom-pipeline commented 10 years ago

Original comment by Cédric Ochs (Bitbucket: [Cédric OCHS](https://bitbucket.org/Cédric OCHS), ).


Should be resolved now :p

ryzom-pipeline commented 10 years ago

Original comment by Jorge Araya Navarro (Bitbucket: [Jorge Araya Navarro](https://bitbucket.org/Jorge Araya Navarro), ).


@kervala so, if I'm providing the game client to use with the official servers, I should get the source code from "compatibility" branch instead from "default"? (just to be clear)

ryzom-pipeline commented 10 years ago

Original comment by Cédric Ochs (Bitbucket: [Cédric OCHS](https://bitbucket.org/Cédric OCHS), ).


Yes :) "default" branch will break compatiblity soon or later, so it's a good idea to already switch to "compatibility" branch.

ryzom-pipeline commented 10 years ago

Original comment by Jorge Araya Navarro (Bitbucket: [Jorge Araya Navarro](https://bitbucket.org/Jorge Araya Navarro), ).


@kervala thanks, you rock! I'll be doing the changes in the respective PKGBUILD to reflect this precautions!

ryzom-pipeline commented 10 years ago

Original comment by Cédric Ochs (Bitbucket: [Cédric OCHS](https://bitbucket.org/Cédric OCHS), ).


You're welcome :)