ryzom / ryzomcore

Ryzom Core is the open-source project related to the Ryzom game. This community repository is synchronized with the Ryzom Forge repository, based on the Core branch.
https://wiki.ryzom.dev
GNU Affero General Public License v3.0
331 stars 89 forks source link

Renaming map markers may load/save wrong marker #15

Closed ryzom-pipeline closed 10 years ago

ryzom-pipeline commented 11 years ago

Original report by Anonymous.


Sometimes (I could not yet figure what triggers the wrong behaviour) when I try to rename map marker A the ryzom client loads the data (name, type) of map marker B. When saving, the new data is displayed in marker A on the map. After relog, marker A is back at the original state, but marker B has the new name and type of the renamed marker A. That means marker B is broken at this point and marker A lost the new data.

The only workaround atm is relog or deleting the marker and recreating it when a player notices the loading error.

Expected behaviour: load data of marker A, save data to marker A, don't touch marker B.

I'm playing the character Janaira on Ryzom/Atys in case of questions. Displayed client version is 2.1.0.

ryzom-pipeline commented 10 years ago

Original comment by Meelis Mägi (Bitbucket: [Meelis Mägi](https://bitbucket.org/Meelis Mägi), ).


This is happening because compass is sorting landmarks, but map has two landmark containers (one of landmarks in .icfg file, other for ui elements, eg flag on map) and their relationship is simple index

how to reproduce:

workaround when this happens:

ryzom-pipeline commented 10 years ago

Original comment by Cédric Ochs (Bitbucket: [Cédric OCHS](https://bitbucket.org/Cédric OCHS), ).


Fixed by @nimetu , thanks a lot :)