search

ryzom / ryzomcore

Ryzom Core is the open-source project related to the Ryzom game. This community repository is synchronized with the Ryzom Forge repository, based on the Core branch.
https://wiki.ryzom.dev
GNU Affero General Public License v3.0
333 stars 90 forks source link

Wind Tree VP not working correcly under Direct3D #160

Closed ryzom-pipeline closed 6 years ago

ryzom-pipeline commented 10 years ago

Original report by Jan Boon (Bitbucket: [Jan Boon](https://bitbucket.org/Jan Boon), ).

The Wind Tree vertex program is not taking into account the vertex weights (vertex buffer channel PrimaryColor), causing the entire trees to dance.

Issue does not occur in the old official Ryzom build.

Issue does not occur with the OpenGL driver.

ryzom-pipeline commented 9 years ago

Original comment by Jan Boon (Bitbucket: [Jan Boon](https://bitbucket.org/Jan Boon), ).

Issue still exists, tested on AMD. Reported to not occur on nVidia.

ryzom-pipeline commented 8 years ago

Original comment by Jan Boon (Bitbucket: [Jan Boon](https://bitbucket.org/Jan Boon), ).

BUMP

ryzom-pipeline commented 8 years ago

Original comment by Cédric Ochs (Bitbucket: [Cédric OCHS](https://bitbucket.org/Cédric OCHS), ).

Thanks a lot, I didn't remember this issue, 2 people reported it yesterday so I thought it was a new bug :p And they didn't precise if they were using D3D driver.

ryzom-pipeline commented 7 years ago

Original comment by Cédric Ochs (Bitbucket: [Cédric OCHS](https://bitbucket.org/Cédric OCHS), ).

More players have this issue since we're migrating all clients to Ryzom Core :)

ryzom-pipeline commented 7 years ago

Original comment by Jan Boon (Bitbucket: [Jan Boon](https://bitbucket.org/Jan Boon), ).

Which graphics cards?

ryzom-pipeline commented 7 years ago

Original comment by Cédric Ochs (Bitbucket: [Cédric OCHS](https://bitbucket.org/Cédric OCHS), ).

Last one was :

Windows 10 x64 Core i5 6600 Intel(R) HD Graphics 530 Driver Intel : 15.40.28.4501 (12/08/2016)

Another one : OpenGL 2.1.0 - Build 8.15.10.2202 / Intel / Intel(R) G45/G43 Express Chipset

Apparently almost users with this issue are using integrated chipsets :(

ryzom-pipeline commented 7 years ago

Original comment by Meelis Mägi (Bitbucket: [Meelis Mägi](https://bitbucket.org/Meelis Mägi), ).

I found a single bool variable that affects dancing trees (1c290dddef2f), not sure what else it breaks tho ;-)

ryzom-pipeline commented 7 years ago

Original comment by Cédric Ochs (Bitbucket: [Cédric OCHS](https://bitbucket.org/Cédric OCHS), ).

Wow, thank you @nimetu ! That's a great discovery :)

ryzom-pipeline commented 7 years ago

Original comment by Guillaume DUPUY (Bitbucket: [Guillaume DUPUY](https://bitbucket.org/Guillaume DUPUY), ).

Great find :-)

ryzom-pipeline commented 7 years ago

Original comment by Jan Boon (Bitbucket: [Jan Boon](https://bitbucket.org/Jan Boon), ).

Makes sense, so the issue would be that the wind weight channel is getting affected by the lighting normalization.

ryzom-pipeline commented 7 years ago

Original comment by Guillaume DUPUY (Bitbucket: [Guillaume DUPUY](https://bitbucket.org/Guillaume DUPUY), ).

Tested on my windows laptop, tree doesn't dance anymore, and my rapid tests haven't showed any issue :)