search

ryzom / ryzomcore

Ryzom Core is the open-source project related to the Ryzom game. This community repository is synchronized with the Ryzom Forge repository, based on the Core branch.
https://wiki.ryzom.dev
GNU Affero General Public License v3.0
338 stars 90 forks source link

NeL build broken on windows 64bits #163

Closed ryzom-pipeline closed 10 years ago

ryzom-pipeline commented 10 years ago

Original report by Kishan Grimout (Bitbucket: kishan_grimout, ).

In mem_displayer.cpp, these don't exist in 64bit version: callStack.AddrPC.Offset = context.Eip; callStack.AddrStack.Offset = context.Esp; callStack.AddrFrame.Offset = context.Ebp;

Instead, use their Rip, Rsp, Rbp equivalents.

Here is the fix I made in my fork : https://bitbucket.org/kishan_grimout/ryzomcore/commits/337c31d

ryzom-pipeline commented 10 years ago

Original comment by Jan Boon (Bitbucket: [Jan Boon](https://bitbucket.org/Jan Boon), ).

Ok, thanks. This is with the Microsoft compiler?

ryzom-pipeline commented 10 years ago

Original comment by Kishan Grimout (Bitbucket: kishan_grimout, ).

Yes, it is.

ryzom-pipeline commented 10 years ago

Original comment by Jan Boon (Bitbucket: [Jan Boon](https://bitbucket.org/Jan Boon), ).

Thanks. Patch merged in. https://bitbucket.org/ryzom/ryzomcore/commits/9fbef431d6f403e92417d37a1b7765af615aee69

ryzom-pipeline commented 10 years ago

Original comment by Jan Boon (Bitbucket: [Jan Boon](https://bitbucket.org/Jan Boon), ).

Could you use tabs instead of spaces, though, for future patches? :)

ryzom-pipeline commented 10 years ago

Original comment by Kishan Grimout (Bitbucket: kishan_grimout, ).

Oh right, forgot to change... working on different projects with different conventions is a mess with Visual only setting this globally