search

ryzom / ryzomcore

Ryzom Core is the open-source project related to the Ryzom game. This community repository is synchronized with the Ryzom Forge repository, based on the Core branch.
https://wiki.ryzom.dev
GNU Affero General Public License v3.0
333 stars 90 forks source link

chatlog improvement #221

Closed ryzom-pipeline closed 9 years ago

ryzom-pipeline commented 9 years ago

Original report by Geyos (Bitbucket: Geyos, GitHub: Geyos).

This is a couple suggestion, some of them might overlap, the idea isn't to implement all of them :-P

1)add @{EE3F}/any prefix on emote log.

At the moment, every (human) message logged is prefixed with a @{EE3F}, where sys info message doesn't have any. It's pretty cool because with a grep "@{EE3F}" you get all your message, the only downside is you don't have any emote because they are logged like sys infos message, without prefix. So the idea here is just to add a prefix (whether is it @{EE3F} or something else) to the emote log

2)An option to remove sys infos message from log

Everything is said, this way you lose sys infos (but it's not that important), but you don't have to clean your logs, and the emote problem isn't one anymore. It's also way easier to find some old conversation manually because you don't have to search through hundreds of sys infos message. See chatlog_quiet.patch for a (simple, without option, just hardcoded) example of this.

3)An option to separate sys infos log from usual log

This one is better than the previous one, imo ; you just log the usual log in log_toonname.txt, and the syslog in a separate file (syslog_toonname.txt), this way you have all the benefits of the previous solution, and you can still access your syslog (if you want to do statistics or i don't know). See chatlog_separate_file.patch for another simple example of this.

ryzom-pipeline commented 9 years ago

Original comment by Jan Boon (Bitbucket: [Jan Boon](https://bitbucket.org/Jan Boon), ).

@{EE3F} is a color tag.

ryzom-pipeline commented 9 years ago

Original comment by Geyos (Bitbucket: Geyos, GitHub: Geyos).

Yes, but in this case it's not used as a color tag ; in fact for every human message you have a @{EE3F} at the beginning of the line, then another color tag (which depends this time on the channel color you configured) before the actual message, for example, a message in universe : (still in the default orange, didn't changed the color) 2014/11/25 13:03:21 @{EE3F}Raded dit : @{F80F}It's a thought. Save me a bunch of focus too... :) Emote message : 2014/11/24 19:28:29 Chaanah fait une révérence des plus courtoises à Geyos. Syslog message : 2014/11/25 13:03:51 * Vous êtes dans le Couloir Brûlé. Cette région est neutre. So there is no good way to distinguish emote from syslog message (except doing an inverse grep/awk/whatever on all the syslog message, but it's a pain in the ass, and you have to do it for every language ...)

ryzom-pipeline commented 9 years ago

Original comment by Jan Boon (Bitbucket: [Jan Boon](https://bitbucket.org/Jan Boon), ).

Ok, so an option in the config to split the sys and regular messages would be the best option then you think?

ryzom-pipeline commented 9 years ago

Original comment by Jan Boon (Bitbucket: [Jan Boon](https://bitbucket.org/Jan Boon), ).

Do you happen to know if and where broadcast and MOTDs end up in the chatlog?

ryzom-pipeline commented 9 years ago

Original comment by Geyos (Bitbucket: Geyos, GitHub: Geyos).

guild MOTD goes into around / usual chatlog (it's acting like an emote it seems) ; mode is not CChatGroup::system. For server MOTD, it's a CChatGroup::system, for broadcast i'm not sure, will do some tests on my ryzomcore server to check. And yes, an option to split it is the best, i think :)

ryzom-pipeline commented 9 years ago

Original comment by Meelis Mägi (Bitbucket: [Meelis Mägi](https://bitbucket.org/Meelis Mägi), ).

why not prefix lines with SYS, BC, EMT, chat type ids?

ryzom-pipeline commented 9 years ago

Original comment by Geyos (Bitbucket: Geyos, GitHub: Geyos).

That would be a good idea nimetu, the only downside is it would break compatibility with existing log analyser (but the fix shouldn't be a big one, and it would be much more clear this way).

Just checked for broadcast (the one with /a broadcast, don't know any other kind of broadcast), it is a CChatGroup::system mode too.

ryzom-pipeline commented 9 years ago

Original comment by Meelis Mägi (Bitbucket: [Meelis Mägi](https://bitbucket.org/Meelis Mägi), ).

How about this? (category/type) both added. Using one or the other depending on type can get too messy.

2015/01/14 20:52:38 (AROUND/SYSTEM) * Welcome to Ryzom!
2015/01/14 20:52:38 (MTD/SYSTEM) * MOTD: Welcome to Atys! In the spring, at the end of the day, you should smell like dirt
2015/01/14 20:52:38 (MTD/GUILD) * Guild message of the day: Hello!
2015/01/14 20:52:38 (ZON/SYSTEM) * You have entered the Wastelands.
2015/01/14 20:55:14 (SYS/DYN2) * @{CC3F}[2 Uni Français] Player says: @{AFBF}moi
2015/01/14 20:56:23 (XP/SYSTEM) * This includes the XP earned for prospecting.
2015/01/14 20:56:23 (ITMF/SYSTEM) * The raw material source was prematurely destroyed.
2015/01/14 20:56:28 (ITM/SYSTEM) * You obtain 10 Fragments of Basic Cuty Shell of quality 50.
2015/01/14 20:56:38 (SYS/GUILD) * @{CC3F}You say: @{BE9F}test
2015/01/14 20:56:42 (SYS/DYN2) * @{CC3F}[2 Uni Français] Player says: @{AFBF}Je peux avoir une pizza ?
2015/01/14 20:56:53 (SYS/SAY) * @{CC3F}You say: @{FFFF}t
2015/01/14 20:57:00 (SYS/SHOUT) * @{CC3F}You shout: @{FF4F}t
2015/01/14 20:59:20 (EMT/SAY) * Player waves at no one in particular.
2015/01/14 21:09:11 (SYS/UNIVERSE) * @{CC3F}Player says: @{F80F}steel..
2015/01/14 21:01:20 (TELL) * @{CC3F}You tell player: @{BBAF}test
2015/01/14 21:01:21 (TELL) * @{CC3F}Player tells you: @{BBAF}test
ryzom-pipeline commented 9 years ago

Original comment by Geyos (Bitbucket: Geyos, GitHub: Geyos).

It seems okay, the only problem i have is SYS (as a category) & SYSTEM (as a type) is kinda confusing :(

ryzom-pipeline commented 9 years ago

Original comment by Meelis Mägi (Bitbucket: [Meelis Mägi](https://bitbucket.org/Meelis Mägi), ).

Added pull request #100 for this. Switched category/type around to type/category and droping SYS which is default anyway

2015/01/14 20:52:38 (SYSTEM/AROUND) * Welcome to Ryzom!
2015/01/14 20:52:38 (SYSTEM/MTD) * MOTD: Welcome to Atys! In the spring, at the end of the day, you should smell like dirt
2015/01/14 20:52:38 (GUILD/MTD) * Guild message of the day: Hello!
2015/01/14 20:52:38 (SYSTEM/ZON) * You have entered the Wastelands.
2015/01/14 20:55:14 (DYN2) * @{CC3F}[2 Uni Français] Player says: @{AFBF}moi

Type is from CChatGroup and possible categories from client_default.cfg file

ryzom-pipeline commented 9 years ago

Original comment by Jan Boon (Bitbucket: [Jan Boon](https://bitbucket.org/Jan Boon), ).

Was merged