Closed ryzom-pipeline closed 8 years ago
Original comment by Cédric Ochs (Bitbucket: [Cédric OCHS](https://bitbucket.org/Cédric OCHS), ).
Yep, I agree :( I'm currently using OpenAL driver and I have no crash related to it at the moment.
Original comment by Jan Boon (Bitbucket: [Jan Boon](https://bitbucket.org/Jan Boon), ).
Does this happen often or not?
Original comment by Cédric Ochs (Bitbucket: [Cédric OCHS](https://bitbucket.org/Cédric OCHS), ).
I think I can reproduce it everytime if I play really more than 30 minutes (travel on a mektoub in my case).
Btw another player got this assert :
2015/11/07 21:03:20 AST 1f38 ryzom_client_r.exe source_xaudio2.cpp 281 NLSOUND::CSourceXAudio2::submitBuffer : "ibuffer->getFormat() == _Format && ibuffer->getChannels() == _Channels && ibuffer->getBitsPerSample() == _BitsPerSample"
Original comment by Jan Boon (Bitbucket: [Jan Boon](https://bitbucket.org/Jan Boon), ).
Add some extra checks, ref #254
Original comment by Jan Boon (Bitbucket: [Jan Boon](https://bitbucket.org/Jan Boon), ).
Try with these changes
Original comment by Jan Boon (Bitbucket: [Jan Boon](https://bitbucket.org/Jan Boon), ).
This seems like a good idea as well, ref #254
Original comment by Cédric Ochs (Bitbucket: [Cédric OCHS](https://bitbucket.org/Cédric OCHS), ).
Thanks a lot, I'll try :)
Original comment by Cédric Ochs (Bitbucket: [Cédric OCHS](https://bitbucket.org/Cédric OCHS), ).
Ah, I noticed something with Windows 10, but if I use XAUDIO2_DEBUG_ENGINE flag in Debug, I got :
2015/11/15 13:49:31 DBG 18c0 ryzom_client_d.exe audio_mixer_user.cpp 368 NLSOUND::CAudioMixerUser::initDriver : AM: Init Driver 'XAudio2' ('xaudio2')...
2015/11/15 13:49:31 DBG 18c0 ryzom_client_d.exe dynloadlib.cpp 207 NLMISC::CLibrary::loadLibrary : Loading dynamic library 'nel_drv_xaudio2_win_d.dll'
2015/11/15 13:49:31 WRN 18c0 ryzom_client_d.exe sound_driver_xaudio2.cpp 152 NLSOUND::CSoundDriverXAudio2::CSoundDriverXAudio2 : XA2: Creating CSoundDriverXAudio2
2015/11/15 13:49:31 INF 18c0 ryzom_client_d.exe sound_driver_xaudio2.cpp 212 NLSOUND::CSoundDriverXAudio2::release : XA2: Releasing CSoundDriverXAudio2
2015/11/15 13:49:31 INF 18c0 ryzom_client_d.exe common.cpp 621 NLMISC::Exception::Exception : Exception will be launched: XA2: XAudio2 failed to initialize. Please install the latest version of the DirectX End-User Runtimes.
2015/11/15 13:49:31 WRN 18c0 ryzom_client_d.exe audio_mixer_user.cpp 391 NLSOUND::CAudioMixerUser::initDriver : XA2: XAudio2 failed to initialize. Please install the latest version of the DirectX End-User Runtimes.
2015/11/15 13:49:31 WRN 18c0 ryzom_client_d.exe init.cpp 1422 postlogInit : init : Error when creating 'SoundMngr' : XA2: XAudio2 failed to initialize. Please install the latest version of the DirectX End-User Runtimes.
But if I remove the flag, it works :)
Original comment by Cédric Ochs (Bitbucket: [Cédric OCHS](https://bitbucket.org/Cédric OCHS), ).
I played some minutes, it didn't crash in XAudio2 driver this time, but in OpenGL one :p I kept the crashlog and I'll retry to see if your changes fixed the crash :)
Original comment by Cédric Ochs (Bitbucket: [Cédric OCHS](https://bitbucket.org/Cédric OCHS), ).
I played again some times and it didn't crash, I even listened songs in music player to force the use of driver :)
I'll continue to play with it but it's possible you fixed the crashes :) Great job !
I'll compile new clients for Steam with your changes so other beta-testers will be able to check that too :)
Original comment by Jan Boon (Bitbucket: [Jan Boon](https://bitbucket.org/Jan Boon), ).
Can you give a new client.log with the changes? I want to confirm something.
Original comment by Cédric Ochs (Bitbucket: [Cédric OCHS](https://bitbucket.org/Cédric OCHS), ).
New log :)
Original comment by Cédric Ochs (Bitbucket: [Cédric OCHS](https://bitbucket.org/Cédric OCHS), ).
Here is the new client.log :)
Original comment by Jan Boon (Bitbucket: [Jan Boon](https://bitbucket.org/Jan Boon), ).
Please confirm that it's fixed, thanks. :)
Original comment by Cédric Ochs (Bitbucket: [Cédric OCHS](https://bitbucket.org/Cédric OCHS), ).
I just recompiled the whole client and I'll play in Debug :)
Btw, last time I played in Debug, assert weren't catched by VC++ because to a wrong boolean value :(
Original comment by Cédric Ochs (Bitbucket: [Cédric OCHS](https://bitbucket.org/Cédric OCHS), ).
I played a lot this afternoon (with XAudio2 driver) in Debug and it didn't crash :)
Original report by Cédric Ochs (Bitbucket: [Cédric OCHS](https://bitbucket.org/Cédric OCHS), ).
It crashed on : if (_SourceVoice) _SourceVoice->SetVolume(_Gain, _OperationSet);
With stacktrace :
And current values were :
And _SourceVoice's __vfptr seems invalid :p
I joined my whole client.log for this session.