ryzom / ryzomcore

Ryzom Core is the open-source project related to the Ryzom game. This community repository is synchronized with the Ryzom Forge repository, based on the Core branch.
https://wiki.ryzom.dev
GNU Affero General Public License v3.0
333 stars 90 forks source link

Table "permissions" inconsistent with r2_login.php script #256

Closed ryzom-pipeline closed 8 years ago

ryzom-pipeline commented 8 years ago

Original report by Jonathan Deeds (Bitbucket: JDCodeIt, GitHub: JDCodeIt).


The permissions table that gets created as part of setup using file nel_00001.sql is missing a column DomainID, which is referenced in r2_login.php in the section that creates a user ID for unknown users.

Either the r2_login.php should remove this dependency or the column should be added to the setup script.

Adding DomainID to the table got me past this, but I'm not sure if the column is needed by the rest of the account management system.

CREATE TABLE IF NOT EXISTSpermission( UIdint(10) unsigned NOT NULL DEFAULT '0', ClientApplicationchar(64) NOT NULL DEFAULT 'ryzom', DomainIdint(10) NOT NULL DEFAULT '-1', ShardIdint(10) NOT NULL DEFAULT '-1', AccessPrivilegeset('OPEN','DEV','RESTRICTED') NOT NULL DEFAULT 'OPEN', primint(10) unsigned NOT NULL ) ENGINE=InnoDB AUTO_INCREMENT=13 DEFAULT CHARSET=utf8;

ryzom-pipeline commented 8 years ago

Original comment by Jan Boon (Bitbucket: [Jan Boon](https://bitbucket.org/Jan Boon), ).


This column is added by sql_00002.

Unless someone fucked with sql_00001, these should be added sequentially.