search

ryzom / ryzomcore

Ryzom Core is the open-source project related to the Ryzom game. This community repository is synchronized with the Ryzom Forge repository, based on the Core branch.
https://wiki.ryzom.dev
GNU Affero General Public License v3.0
339 stars 90 forks source link

V3 Client install failure #302

Closed ryzom-pipeline closed 7 years ago

ryzom-pipeline commented 7 years ago

Original report by Teeneemai BaRiroy (Bitbucket: Teeneemai, ).

When installing the V3 Client, using the installer, some people are getting a warning message stating that they have insufficient disc space free, when in fact they have more than enough available.

ryzom-pipeline commented 7 years ago

Original comment by Cédric Ochs (Bitbucket: [Cédric OCHS](https://bitbucket.org/Cédric OCHS), ).

Hi :) Thanks for the report :)

Please could you check installer.log to see if there is some warning or error messages ?

What OS are they using ? Did they create/use symbolic links ? Are they using system encryption ?

You can also add "ignore_free_disk_space_checks=true" to ryzom_instailler.ini in "[common]" section.

ryzom-pipeline commented 7 years ago

Original comment by Guillaume DUPUY (Bitbucket: [Guillaume DUPUY](https://bitbucket.org/Guillaume DUPUY), ).

On 32 bits system, stfs.f_bavail and stfs.f_bsize are 32 bits wide ; this means that a multiplication between the two (as CSystemInfo::availableHDSpace is doing) rapidly results in an overflow, and CSystemInfo::availableHDSpace() returning at most 2^32, which is less than ryzom size (around 7 GB). PR #155 fix the issue.

Attached reproduction code

ryzom-pipeline commented 7 years ago

Original comment by Cédric Ochs (Bitbucket: [Cédric OCHS](https://bitbucket.org/Cédric OCHS), ).

@Glorf Thanks a lot for the fix :)

ryzom-pipeline commented 7 years ago

Original comment by Cédric Ochs (Bitbucket: [Cédric OCHS](https://bitbucket.org/Cédric OCHS), ).

Fix issue #302 - incorrect freespace on 32 bits system

ryzom-pipeline commented 7 years ago

Original comment by Cédric Ochs (Bitbucket: [Cédric OCHS](https://bitbucket.org/Cédric OCHS), ).

Merged in Glorf/ryzomcore/fix_freespace_check (pull request #155)

Fix issue #302 - incorrect freespace on 32 bits system

Approved-by: Cédric OCHS kervala@gmail.com

ryzom-pipeline commented 7 years ago

Original comment by Guillaume DUPUY (Bitbucket: [Guillaume DUPUY](https://bitbucket.org/Guillaume DUPUY), ).

Shows why it's much easier to debug a bug when you have information about it :-) Thanks for the report from Caileen (who said it was on a 32 bit system which obviously helped quite a lot)