search

ryzom / ryzomcore

Ryzom Core is the open-source project related to the Ryzom game. This community repository is synchronized with the Ryzom Forge repository, based on the Core branch.
https://wiki.ryzom.dev
GNU Affero General Public License v3.0
333 stars 90 forks source link

how to build with visual studio 2017 on windows 10 ? #318

Closed ryzom-pipeline closed 6 years ago

ryzom-pipeline commented 6 years ago

Original report by Rocker Irwin (Bitbucket: mightee, GitHub: mightee).

there is no way of installing visual studio tools for 2010 on windows 10 as .net framework 4 is part of the windows 10 sdk.

ryzom-pipeline commented 6 years ago

Original comment by Cédric Ochs (Bitbucket: [Cédric OCHS](https://bitbucket.org/Cédric OCHS), ).

http://forge.ryzom.com/wiki/Building_Ryzom_Client_On_Windows

It works fine with Visual C++ 2015 and I didn't yet compile external for VC++ 2017 :(

ryzom-pipeline commented 6 years ago

Original comment by Rocker Irwin (Bitbucket: mightee, GitHub: mightee).

https://ryzomcore.atlassian.net/wiki/spaces/RC/pages/884838/Build+Source+on+Windows this page is then outdated. documentation should be in one place. sigh..

ryzom-pipeline commented 6 years ago

Original comment by Kishan Grimout (Bitbucket: kishan_grimout, ).

From what I know, binaries built with Vs 2015 are compatible with Vs 2017, so external libs from your 2015 version should still work. I'm currently trying to build client and server with 2017, but as the directories have changed, the FindMsvc.cmake fails to properly detect the standard include path. I had no time to investigate further yet. Any official support would be welcome!

ryzom-pipeline commented 6 years ago

Original comment by Rocker Irwin (Bitbucket: mightee, GitHub: mightee).

I was going to edit the FindMsvc.make file but I am lazy for that. So I just installed vs 2015 and everything is fine now.

ryzom-pipeline commented 6 years ago

Original comment by Rocker Irwin (Bitbucket: mightee, GitHub: mightee).

vs 2015 did the trick

ryzom-pipeline commented 6 years ago

Original comment by Kishan Grimout (Bitbucket: kishan_grimout, ).

Well, it doesn't feel resolved to me as your solution doesn't fix the issue you reported.

FYI, after investigating a bit more FindMsvc.cmake, it appears that the look-up in the registry returns wrong information, so I "fixed" it by only use the "fallback" detection method (at end of the script) that uses the CMAKE_CXX_COMPILER variable to look for the standard include directory. In my fork, I removed everything else so that may be a bit extreme to merge back here, but at least, that gives you a hint.

And also note that the external libraries built against VC 2015 are working just fine! (found on the sourceforge project page, in case someone else is looking for it)

Hope this helps!

ryzom-pipeline commented 6 years ago

Original comment by Cédric Ochs (Bitbucket: [Cédric OCHS](https://bitbucket.org/Cédric OCHS), ).

I just fixed all support for VC++ 2017 in CMake modules for my personal projects, I'll update Ryzom Core modules soon :) Btw VC++ 2017 is still a VC++ 14.0 compiler like VC++ 2015 (at least 14.10 and 14.11) so it's using the same version of C++ runtimes.

ryzom-pipeline commented 6 years ago

Original comment by Cédric Ochs (Bitbucket: [Cédric OCHS](https://bitbucket.org/Cédric OCHS), ).

It should be fixed now :) I'll commit new updated external (with new versions of libs) soon too but current one should work :)

ryzom-pipeline commented 6 years ago

Original comment by Cédric Ochs (Bitbucket: [Cédric OCHS](https://bitbucket.org/Cédric OCHS), ).

New external has been uploaded on sourceforge : https://sourceforge.net/projects/ryzom/files/

I also uploaded static versions of Qt 5.9.1