search

ryzom / ryzomcore

Ryzom Core is the open-source project related to the Ryzom game. This community repository is synchronized with the Ryzom Forge repository, based on the Core branch.
https://wiki.ryzom.dev
GNU Affero General Public License v3.0
333 stars 90 forks source link

ingame MP3 player; "open" button does nothing #59

Closed ryzom-pipeline closed 8 years ago

ryzom-pipeline commented 10 years ago

Original report by SirCotare (Bitbucket: SirCotare, GitHub: SirCotare).

The ingame MP3 player is doing nothing when clicking on the "open" button which is supposed to let you select files. The issue was reported several times running Win7x64 but seems to be random. Others reported, that it worked even on the same OS.

ryzom-pipeline commented 10 years ago

Original comment by Cédric Ochs (Bitbucket: [Cédric OCHS](https://bitbucket.org/Cédric OCHS), ).

Thanks, I think this is the same bug/feature as http://dev.ryzom.com/issues/1035 but it wasn't yet on bitbucket :)

Under Windows, we are using Win32 functions to select a file, but there is no equivalent under X11. So we need to add a dependency to Qt or GTK+ or (I think that's the best solution) use the same Lua function as in the Ring to select a file.

So the file selector will be identical under Windows and Linux and will be better integrated with Ryzom UI.

ryzom-pipeline commented 10 years ago

Original comment by Cédric Ochs (Bitbucket: [Cédric OCHS](https://bitbucket.org/Cédric OCHS), ).

And it could also be related with file format and driver compatibility. Only Fmod driver is supporting MP3 and all drivers are supporting ogg vorbis.

ryzom-pipeline commented 10 years ago

Original comment by Cédric Ochs (Bitbucket: [Cédric OCHS](https://bitbucket.org/Cédric OCHS), ).

I tried and the file selector is not displayed if no working NeL audio driver is loaded.

ryzom-pipeline commented 9 years ago

Original comment by Jan Boon (Bitbucket: [Jan Boon](https://bitbucket.org/Jan Boon), ).

A proper ingame file selection should be added (so that it's usable from within a HMD).

ryzom-pipeline commented 8 years ago

Original comment by Cédric Ochs (Bitbucket: [Cédric OCHS](https://bitbucket.org/Cédric OCHS), ).

Little up of this issue, it will be cool if someone could create a little interface in XML/Lua to load files and start MP3 player with them :)

ryzom-pipeline commented 8 years ago

Original comment by Meelis Mägi (Bitbucket: [Meelis Mägi](https://bitbucket.org/Meelis Mägi), ).

What if skip building filemanager in lua and just read ogg/mp3/m3u files from directory? 'music' or 'music_player' inside ryzom maybe.

ryzom-pipeline commented 8 years ago

Original comment by Cédric Ochs (Bitbucket: [Cédric OCHS](https://bitbucket.org/Cédric OCHS), ).

That's a good idea :) And we could implement a file selector later :p

ryzom-pipeline commented 8 years ago

Original comment by Meelis Mägi (Bitbucket: [Meelis Mägi](https://bitbucket.org/Meelis Mägi), ).

commit 317b000 adds directory scanning for all platforms.

In the client release, there should be music/README file instructing to drop .mp3, .ogg, .m3u/m3u8 files to that directory. Currently it's not clear how media player works.

btw, mp3 player does not actually play mp3's in linux :-)

ryzom-pipeline commented 8 years ago

Original comment by Cédric Ochs (Bitbucket: [Cédric OCHS](https://bitbucket.org/Cédric OCHS), ).

Thanks a lot :) mp3 is only supported with fmod driver :(

I'm checking what API we could use to support more formats (without needing to add new dependencies). Under Windows, we have choice between MCI and DirectShow. I was using DirectShow at work but I didn't know MCI. Apparently, it's very high level oriented and simple to use (I'm playing a mp3 with less than 10 lines of C code) :p