ryzom / ryzomcore

Ryzom Core is the open-source project related to the Ryzom game. This community repository is synchronized with the Ryzom Forge repository, based on the Core branch.
https://wiki.ryzom.dev
GNU Affero General Public License v3.0
343 stars 90 forks source link

Protect IOS from data leakage #604

Open kaetemi opened 4 years ago

kaetemi commented 4 years ago

The IOS stores static strings in a cache, the client can request these by numeric value. The numeric values are sequential, which is handy for fast lookups on the server.

However, it's possible to abuse this mechanism to download all serverside static strings. This leaks private guild MOTD, and may spoil leveldesign texts.

Two proposed solutions:

mlcdev commented 4 years ago

Randomly skip identifiers, and instantly permaban any account that attempts to request invalid identifiers.

Bug in client could lead to request and mass ban of innocent players.

kaetemi commented 4 years ago

Hahaha. "bug" ;)