Deleted shortcuts are restored after client restart - Githubissues

ryzom / ryzomcore

Ryzom Core is the open-source project related to the Ryzom game. This community repository is synchronized with the Ryzom Forge repository, based on the Core branch.

https://wiki.ryzom.dev

GNU Affero General Public License v3.0

330 stars 89 forks source link

Deleted shortcuts are restored after client restart #671

Open vgaming opened 1 year ago

vgaming commented 1 year ago

Hi Ryzom team! I've noticed a potential bug with deleted shortcuts handling

Steps to reproduce:

Start Ryzom, open Settings > Keys
Click on an existing shortcut, select "Delete Key"
Observe the key being deleted in the shortcut list
Click "SAVE"
Quit the client normally
(Optionally) Check the _keys.xml file in profile directory and observe this particular shortcut being deleted
Start Ryzom again

Expected at this point:

The deleted shortcut not working. Since I've intentionally deleted the key and observed it not working and visually removed from the list, I expect it to not work after a restart as well

Actually observed at this point:

The default shortcut is working again, allowing you to e.g. accidentally press it and have undesired behavior
The shortcut information gets added back to _keys.xml file in profile directory

System:

Up-to-date ArchLinux
Ryzom installed via the official installer (I want to play with building Ryzom from source as well, but later, not a priority and not related to this issue)

Thoughts? Thanks!

vgaming commented 1 year ago

Player Gilgameesh (in Ryzom chat) observes that the shortcuts stay deleted on their system forever. They use Windows. This difference in behavior adds to the understanding that it's a bug

Player Karnij has confirmed observing the same behavior as I have (of erasing shortcuts) on their system. They use Linux as well.