search

ryzom / ryzomcore

Ryzom Core is the open-source project related to the Ryzom game. This community repository is synchronized with the Ryzom Forge repository, based on the Core branch.
https://wiki.ryzom.dev
GNU Affero General Public License v3.0
331 stars 89 forks source link

AMS Static calling #72

Closed ryzom-pipeline closed 10 years ago

ryzom-pipeline commented 10 years ago

Original report by Matthew Lagoe (Bitbucket: botanic, GitHub: botanic).

When i login to the new AMS i get

( ! ) Strict standards: Non-static method WebUsers::isLoggedIn() should not be called statically in C:\development\rc-botanic-webdev\code\ryzom\tools\server\ryzom_ams\www\html\inc\dashboard.php on line 12

ryzom-pipeline commented 10 years ago

Original comment by Matthew Lagoe (Bitbucket: botanic, GitHub: botanic).

I also get

( ! ) Strict standards: Non-static method WebUsers::checkLoginMatch() should not be called statically in C:\development\rc-botanic-webdev\code\ryzom\tools\server\ryzom_ams\www\html\func\login.php on line 15

When I login with a bad user/pass

ryzom-pipeline commented 10 years ago

Original comment by Daan Janssens (Bitbucket: DJanssens, GitHub: DJanssens).

Aha, weird, I got php_error_checking on but they didn't pop up here. Anyway, I can solve that quite easily :) Though iirc it's just a warning, php seems to be smart enough to call it even though it's a static.

ryzom-pipeline commented 10 years ago

Original comment by Matthew Lagoe (Bitbucket: botanic, GitHub: botanic).

Resolved with pull request #33 Merged