rzane / baby_squeel

:pig: An expressive query DSL for Active Record
MIT License
500 stars 49 forks source link

The 5.2 Builds are failing with the latest ransack version. #121

Closed rocket-turtle closed 2 years ago

rocket-turtle commented 2 years ago

ransack - 2.6.0 - 2022-03-08

https://github.com/activerecord-hackery/ransack/blob/master/CHANGELOG.md

Solution 1: Fix the version of ransack Solution 2: Drop support for ActiveRecord older than 6.0.

rocket-turtle commented 2 years ago

I think the 1.4.4 version of baby_squeel for Rails 5.2 is stable and does not need any more fixes for the Rails 5.2. So we could make a 1.5 only for Rails 6.0 and above https://github.com/rzane/baby_squeel/pull/122

@rzane ransack did it in a patch version. What do you think?