rzane / baby_squeel

:pig: An expressive query DSL for Active Record
MIT License
500 stars 49 forks source link

Rails 5.2 support #85

Closed kylekermgard closed 6 years ago

kylekermgard commented 6 years ago

It looks like baby_squeel isn't working with joins in rails 5.2.0.beta2.

rzane commented 6 years ago

Yup, this is a top priority. I'll work on this ASAP.

rzane commented 6 years ago

Okay, I spend some time looking into this. It should be solvable, but it's going to take quite a bit more research. So far, I've identified the source of the changes that caused 5.2 to break:

Also, most of the failures are due to missing or extra parens in the generated SQL.

rzane commented 6 years ago

I'm working on this in #87. It's really close!

kapso commented 6 years ago

has_many & has_one via through is breaking on Rails 5.2 because of this gem

rzane commented 6 years ago

Yeah 5.2 is currently broken. Support for 5.2 waiting on this PR: https://github.com/rzane/baby_squeel/pull/87