rzcoder / node-rsa

Node.js RSA library
1.39k stars 205 forks source link

Update dependencies and support running in browser #228

Closed kinland closed 9 months ago

kinland commented 1 year ago

This PR does two things:

This includes changes from @learntheropes 's fork for running node-rsa in the browser out of the box. The main thing their fork does is use the buffer package instead of assuming Buffer was available. Their fork did not make this a conditional change, which means someone using @learntheropes/node-rsa in node will end up using the npm package rather than the node one. My changes address this.

rzcoder commented 9 months ago

Works in browser out of the box via conditional polyfills

sounds too strong considering that using it in the browser still requires bundling