rzeldent / esp32-smartdisplay

PlatformIO library LVGL Drivers for Sunton Smart display boards (CYD Cheap Yellow Display). This library supports these boards without any effort. ESP32-2432S024N/R/C, ESP32-2432S028R/C, ESP32-3248S035R/C, ESP32_8048S070N/C
https://github.com/rzeldent/platformio-espressif32-sunton
GNU General Public License v3.0
385 stars 69 forks source link

-D TFT_ORIENTATION_PORTRAIT_INV only changes touch orientation but not tft #10

Closed NiklasVoigt closed 1 year ago

NiklasVoigt commented 1 year ago

I am using the ESP32_3248S035C. As the title says, the build flag TFT_ORIENTATION_PORTRAIT_INV only changes the touch orientation but not the tft orientation.

build_flags =

LVGL settings

-D LV_CONF_PATH=${platformio.include_dir}/lv_conf.h
# Smartdisplay settings
-D TFT_PANEL_ORDER_RGB
-D TFT_ORIENTATION_PORTRAIT_INV
-D ESP32_3248S035C
rzeldent commented 1 year ago

Hi Niklas,

I looked at the code but do not see a reason why this works differently than on my board. Is this still a problem?

NiklasVoigt commented 1 year ago

Yes, this is still a problem.

rzeldent commented 1 year ago

Hi Niklas,

Found the issue. Please check the branch at https://github.com/rzeldent/esp32-smartdisplay/tree/bugfix/display_orientation Let me know if this works for you...

Rene

On Sun, Mar 12, 2023 at 3:24 PM NiklasVoigt @.***> wrote:

Yes, this is still a problem.

— Reply to this email directly, view it on GitHub https://github.com/rzeldent/esp32-smartdisplay/issues/10#issuecomment-1465213131, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2ENBY7GE7SEBCCMLEEKUTW3XMCBANCNFSM6AAAAAAVWQZ4LY . You are receiving this because you commented.Message ID: @.***>

rzeldent commented 1 year ago

Created a test project https://github.com/rzeldent/esp32-smartdisplay-demo and tested the. orientation. Error was because of incorrect ifdefs. Should be fixed now and is already merged into the main branch. This will become version 1.0.5

Thanks for mentioning this bug!

NiklasVoigt commented 1 year ago

Hi Rene, fixed!