search

rzeldent / esp32-smartdisplay

PlatformIO library LVGL Drivers for Sunton Smart display boards (CYD Cheap Yellow Display). This library supports these boards without any effort. ESP32-2432S024N/R/C, ESP32-2432S028R/C, ESP32-3248S035R/C, ESP32_8048S070N/C
https://github.com/rzeldent/platformio-espressif32-sunton
GNU General Public License v3.0
430 stars 75 forks source link

lvgl 9.2.1 breaks develop branch #208

Closed twiesenthal closed 1 month ago

twiesenthal commented 1 month ago

Hi,

i'm fairly new to esp32 programming and using esp32-smartdisplay in general, so i don't feel confident enough to provide a fox for this in a merge request. But i would like to let you know that with the merge from this issue, which was included in lvgl 9.2.1 yesterday, the develop branch is currently broken

sw_rotate was removed which results in build time errors like this. 

esp32_smartdisplay/src/esp32_smartdisplay.c:197:15: error: 
'lv_display_t' {aka 'struct lv_display_t'} has no member named 'sw_rotate'

The simple solution is of course to pin the lvgl version to 9.2.0 in library.json, but that does not seem sustainable to me. Maybe someone more confident with the code can fix the root cause of the error.

applabstudio commented 1 month ago

Same error

rzeldent commented 1 month ago

Just committed fix for rotation. https://github.com/rzeldent/esp32-smartdisplay/tree/lvgl9.2

Does this work for you?

bobskigit commented 1 month ago

it works for me

rzeldent commented 1 month ago

Retested on software rotation device esp32-4848S040CIY1. Worked as expected.

PR to have this in the develop branch. https://github.com/rzeldent/esp32-smartdisplay/pull/210

twiesenthal commented 1 month ago

Thank you very much @rzeldent. Works like a charm