rzellem / EXOTIC

EXOplanet Transit Interpretation Code
Other
86 stars 45 forks source link

FOV Legend to either display annulus or aperture depending on optimal method chosen #1303

Closed IraLeeBell closed 1 month ago

IraLeeBell commented 2 months ago

In discussions with @tamimfatahi on the field of view update, he had a nice suggestion that we should either display annulus or aperature, depending on the optimal method chosen by EXOTIC (i.e., PSF Photometry / Aperture Photometry).

IraLeeBell commented 2 months ago

I think the changes I made in the recent branch are ok here. I did test and it works ok when the optimal method is PSF Photometry (see below). We probably need to see a test when the optimal method is Aperture Photometry. We can hard code a test for this, or if someone comes across a reduction that we can use to test that would be helpful! FOV_Kepler-686 b_9-13-2024_SquaredStretch

IraLeeBell commented 2 months ago

I had a run which selected Aperture Photometry today, and thus a different legend appeared as expected. I note that we do have a red circle on the star. Will discuss in slack and report back here. FOV_Qatar-5 b_9-24-2024_SquaredStretch

IraLeeBell commented 2 months ago

Fixed to ensure outer circle is also red, rather than lime green, when aperture photometry is selected as the optimal method. Creating pull request.

FOV_Qatar-5 b_9-24-2024_SquaredStretch