rzellem / EXOTIC

EXOplanet Transit Interpretation Code
Other
86 stars 45 forks source link

Issue 1303: FOV legend to display annulus/aperture based on chosen optimization #1304

Closed IraLeeBell closed 1 month ago

IraLeeBell commented 2 months ago

Updates: Legend in Field of View now only shows annulus (in lime) or aperture (in red) depending on optimal method chosen when exotic is run (aperture photometry vs aperture photometry)

Impact: small update to exotic.py when plot_fov is called, update to plots.py for the plot_fov function including receiving opt_method so we can declare the optimal method from exotic.py at the time the function is called

IraLeeBell commented 2 months ago

Qatar-5-b-green-outer-circle.zip Qatar-5-b-red-outer-circle.zip

IraLeeBell commented 2 months ago

The above zip files show the images_output folders for the lime green outer circle, and the red outer circle (the current state of the PR) when aperture photometry is chosen. If anyone needs the actual FITS files (and darks) please ping me (this example data set that produces the aperture photometry optimal method result is 500+ images @ 33.6 MB each).

tamimfatahi commented 1 month ago

Hey @IraLeeBell! Do you happen to need any assistance on this to follow-up on Kyle's comments?

IraLeeBell commented 1 month ago

Hey @IraLeeBell! Do you happen to need any assistance on this to follow-up on Kyle's comments?

@tamimfatahi @pearsonkyle - I will work on these changes tomorrow morning (10/3/24)!

tamimfatahi commented 1 month ago

Hey @IraLeeBell! Do you happen to need any assistance on this to follow-up on Kyle's comments?

@tamimfatahi @pearsonkyle - I will work on these changes tomorrow morning (10/3/24)!

No rush! Just checking in :)

IraLeeBell commented 1 month ago

@pearsonkyle - I think this is probably good to go, provided that you're happy with the layout of the legends. Here are examples of PSF Photometry and Aperture Photometry FOV outputs. FOV_TrES-3 b_9-26-2024_SquaredStretch FOV_WTS-2 b_9-23-2024_SquaredStretch

IraLeeBell commented 1 month ago

Full output of each run in above examples attached here. WTS-2-b-PSF-Photometry.zip TrES-3-b-Aperture-Photometry.zip

pearsonkyle commented 1 month ago

The code changes look good but please pull into the develop branch