Open ivenzor opened 2 hours ago
I'm working on a PR.
Let's hold off on increasing the limit. I recommend we keep it at 10 since too many comparison stars can increase the runtime exponentially. Maybe we ignore the limit when adding AAVSO comp star.
Once Issue #1316 is merged into develop, please implement the suggestion above. I don't want you working on a solution when the code is being changed.
There is a hardcoded limit of 10 comparison stars that a user may select. If there are more than 10, the user must re-enter the comparison stars. We could change the limit to 20. If a user takes the time to manually choose 10 or more comparison stars, the additional runtime likely wouldn’t be a significant issue. See this conversation on Slack: https://uol-ets.slack.com/archives/CJJRP4QKV/p1729586384135459
The current limit is hardcoded in
inputs.py
within thecomparison_star_coords
function: