rzhan97 / Hey-Hey-Miu

0 stars 0 forks source link

Default python modules in requirements.txt #3

Open rfazeli opened 2 years ago

rfazeli commented 2 years ago

The following 3 modules should be removed from requirements.txt since they are default Python modules and don't need to be pip installed.

  1. json
  2. time
  3. random

In fact, if they're not removed, the pip install -r requirements.txt command will fail as those packages are not on pypi.

requests json time pandas numpy matplotlib seaborn random surprise

rfazeli commented 2 years ago

There were actually some packages missing from your requirements.txt file. Since I didn't have access to your virtual environment to run pip freeze > requirements.txt to update the requirements.txt file, I used a package called pipreqs which scans the project and gathers a list of packages that were used in the project. This is the requirements.txt file I used to create my virtual environment.

matplotlib==3.4.3
numpy==1.21.3
pandas==1.3.4
requests==2.26.0
scikit_surprise==1.1.1
scipy==1.7.1
seaborn==0.11.2
selenium==4.1.0
surprise==0.1
tqdm==4.61.0

CONTEXT

I was trying to run the notebooks in your repo and I needed to install all required packages to recreate your environment.