search

rzk-lang / sHoTT

Formalisations for simplicial HoTT and synthetic ∞-categories.
https://rzk-lang.github.io/sHoTT/
45 stars 12 forks source link

Auto-format all files #142

Closed aabounegm closed 11 months ago

aabounegm commented 12 months ago

This PR runs the new auto-formatter for Rzk that implements the style guide. It is currently still under work in https://github.com/rzk-lang/rzk/pull/144, so before it is merged and released, I'd like to make sure that it works as expected, so I ran it on all files in this project (using rzk format --write). This should help find implementation mistakes in the formatter and/or inconsistencies in the style guide (the hopeful best-case scenario would be that it aligns all formalizations with the current style guide 🙂).

Please review these changes and point out any problems or possible improvements.

fredrik-bakke commented 12 months ago

Awesome! I will take the time to review this later this week.

aabounegm commented 11 months ago

@fredrik-bakke Thank you very much for the constructive feedback! I hope that most of the issues have been addressed now. It seems to me that the remaining unresolved conversations are about either inserting line breaks or fixing indentation, both of which are planned for the future as they are not straightforward to implement with the current architecture (opened issues https://github.com/rzk-lang/rzk/issues/147 and https://github.com/rzk-lang/rzk/issues/148). I do not have any other changes planned for this PR, so if you think it is ready to be merged then please approve it so I can merge 😁