search

rzkhosroshahi / zaman

It's a lightweight React component for creating a Jalali/Georgian datepicker
https://rzkhosroshahi.github.io/zaman-landing
MIT License
265 stars 48 forks source link

Modal Problem in relative boxes #15

Closed Vahid-Taheri closed 4 years ago

Vahid-Taheri commented 5 years ago

Hi, In my idea , this issue caused by not following some standards on designing the DOM of modal. You provided an absolute and flex modal in your component. It should be appear at the end of body tag , as other overlays that provided by others(that i mentioned it a a standard). It causes that your absolute overlay depends on body but with your design , it appears where it React tag inserts. If the parent of it would be a box(div or ...) with style "position : relative" it doesn't depend on body dimensions and relative box limits it.

As the summary , it's better that you make changes to make overlay DOM at the end of body to solve this problem.

With love and thanks a lot !

rzkhosroshahi commented 5 years ago

Hey @Vahid-Taheri Thanks, I'm sorry to delay :( I'm too busy Vahid if you can solve this issue free to create a pull request

good luck

mehdiraized commented 4 years ago

hi this pull request

rzkhosroshahi commented 4 years ago

https://github.com/rzkhosroshahi/react-jalali-datepicker/pull/19